Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126907218. |
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
Summary: Pull Request resolved: react#59391 `Pressable`, `TouchableHighlight`, `TouchableOpacity` and `TouchableNativeFeedback` delegate accessibility aliases to `View` instead of reconstructing optional accessibility props. Forward unconsumed Touchable props through `restProps`, preserving touch-specific defaults and existing child props. Use the resolved Pressability disabled state so accessibility and press handling agree, including inherited `aria-disabled` and `accessibilityState.disabled` values. Keep compatibility mappings for non-View native-feedback children. Changelog: [General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components. Differential Revision: D126907218
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 10:04
ba82eaf to
8f40e6b
Compare
Summary: Pull Request resolved: react#59391 `Pressable` and View-backed Touchables delegate accessibility normalisation to `View` and forward unconsumed props with `restProps`, without synthesising noisy default props. Preserve the existing press and focus rules, and let Jest exercise the same normalisation by mocking only the native View boundary. Update the dependent snapshots and native-boundary assertions accordingly. Changelog: [General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 11:05
8f40e6b to
f53e1e0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pressableand View-backed Touchables delegate accessibility normalisation toViewand forward unconsumed props withrestProps, without synthesising noisy default props. Preserve the existing press and focus rules, and let Jest exercise the same normalisation by mocking only the native View boundary. Update the dependent snapshots and native-boundary assertions accordingly.Changelog:
[General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components.
Differential Revision: D126907218