Repository navigation
Conversation
Assisted-by: Claude Code Signed-off-by: lazerg <lazerg2@gmail.com>
Assisted-by: Claude Code Signed-off-by: lazerg <lazerg2@gmail.com>
Contributor
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66942 +/- ##
==========================================
- Coverage 90.60% 90.59% -0.02%
==========================================
Files 797 797
Lines 278276 278281 +5
Branches 53498 53505 +7
==========================================
- Hits 252133 252096 -37
- Misses 16506 16555 +49
+ Partials 9637 9630 -7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dependency that finishes linking before another module asks for it still reports
unlinkeduntilinstantiate(). So every later importer ran[kLink]()on it again and walked its whole subgraph, and with a mix of cached and slow-loading modules the linker call count grew quadratically. Before #52058,ModuleWrap::Linkreturned early in this case.This keeps track of the modules already linked during one
link()call and skips them. The set only lives for that call, solink()can still be retried after a failedinstantiate().Fixes: #66938