Repository navigation
Fix BFS shortest distances for non-single-character node names - #15629
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
8 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Initialize the visited set with the start node itself.
set(start)splits string node names into characters and raisesTypeErrorfor integer node names.For example,
bfs_shortest_path_distance({'AB': ['A'], 'A': ['C'], 'C': []}, 'AB', 'C')returns-1before this fix and2afterward. The edge from integer node0to1now returns1instead of raising.Validation on free-threaded Python 3.15: all 11 existing BFS doctest items pass. An external exhaustive check compares all source/target pairs in every directed four-node graph against Floyd-Warshall, with string, integer and tuple labels: 196,608 comparisons pass. Existing doctests remain unchanged, per the contribution guidance.
AI-assisted contribution.
Checklist