Repository navigation
fix: preserve token boundaries in DDL parameter lists - #2857
Merged
manticore-projects merged 1 commit intoOct 24, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opaque DDL parameter lists concatenate adjacent words and numbers: an Oracle vector index containing PARAMETERS (TYPE HNSW, NEIGHBORS 32) is rendered as PARAMETERS (TYPEHNSW,NEIGHBORS32). The result can still reparse while changing the parameter tokens.
Insert a separator between adjacent list items, preserving existing comma/equals formatting and quoted contents. Tests assert exact toString and StatementDeParser output for HNSW/IVF indexes and table storage options, plus literals, quoted names, booleans and numeric lists.
Syntax reference: Oracle CREATE VECTOR INDEX.
Validation: full Maven
clean verify; Gradlecheckwith Spotless ratcheted toupstream/masterfor this fork checkout; combined-change tests (414 tests) and the 238-input, three-configuration compatibility corpus, with no previously parsing input regressions.